Repository navigation
fix(agc): allow MSAA_ENABLE single-sample rect lists - #6563
Conversation
|
Verified on PPSA03541 stacked with #6549 (local GDS+MSAA AgcDriver): past COPY_DATA GDS and past MSAA_ENABLE rect-list. Title reaches HDR present and issues rect-list draws ( |
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
|
Tested on Linux x86-64 (Release build, lavapipe / llvmpipe LLVM 20.1.2), with f9f67e3 merged into main 31cbb55:
AI-assisted: yes (Claude Code) |
f9f67e3 to
70f9ed4
Compare
70f9ed4 to
193963e
Compare
|
Rebase handoff — rebased onto current Verified on Linux (CachyOS, kernel 7.2.9, GCC 16.2.1, Ninja, Release,
To pick it up: Head is |
|
Tested on PPSA03541 (EA SPORTS UFC 5, content version 01.031.000): Windows 11, RTX 5090, NVIDIA 617.42, WinLibs GCC 15.2.0. After #6549, the title stopped here with "MSAA_ENABLE on a single-sample target for primitives other than triangles is unsupported (register 0x242 = 0x00000007)" about 20 s in. This PR cannot be applied to main as it is: main has been refactored, and AI-assisted: yes. Written with AI assistance and reviewed by me. |
Filled rectangles (VGT_PRIMITIVE_TYPE 7 and 17) use the same single-sample MSAA_ENABLE path as triangles; PPSA03541 stops on a rect-list draw otherwise. Co-authored-by: Cursor <cursoragent@cursor.com>
193963e to
92f11a9
Compare
|
Main moved again ( Added as our own commit on your branch:
Merging once the Build run is green. Thanks to @coltken95, @blawesom and @klosixgaming-arch for the runs. |
What
MSAA_ENABLEon a one-sample target already accepts filled triangles (VGT_PRIMITIVE_TYPE4-6). Rect lists (7) and the alternate rectangle type (17) produce the same filled coverage, so they use that path instead of throwing. Points and lines still throw.EA Sports UFC 5 (PPSA03541) stops on a rect-list draw with
MSAA_ENABLEandMSAA_NUM_SAMPLES = 0after COPY_DATA GDS.Tested
Windows 10, WinLibs GCC 15.2.0.
agc_driver_graphicspasses.tools/check_conventions.py --base upstream/mainpasses. PPSA03541: retested with the rebuilt driver after this change.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)Made with Cursor